Improve release workflow #4307

jesseduffield · 2025-02-22T11:46:20Z

the cron schedule was wrong: it was doing every saturday, rather than the first saturday of each month.
It wasn't triggering a deploy despite pushing a tag because clearly github doesn't want that to happen.

Now it triggers a deploy, and it also allows triggering from the UI, letting you specify minor/patch bump and whether to ignore blocking PRs/issues. As such I'm removing support for the old method of pushing the tag. The new way is the only way.

PR Description
Please check if the PR fulfills these requirements

Cheatsheets are up-to-date (run go generate ./...)
Code has been formatted (see here)
Tests have been added/updated (see here for the integration test guide)
Text is internationalised (see here)
If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
Docs have been updated if necessary
You've read through your own file changes for silly mistakes etc

codacy-production · 2025-02-22T11:48:51Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `2ceecad`¹	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`2ceecad`)	Report Missing	Report Missing	Report Missing
Head commit (`fcf48c4`)	53088	45982	86.61%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4307)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

jesseduffield · 2025-02-22T11:49:25Z

.github/workflows/release.yml

+        with:
+          go-version: 1.22.x
+
+      - name: Run goreleaser


Goreleaser/homebrew now happen sequentially rather than in parallel, because speed is not important and it reduces the chance of issues from one step failing and the other succeeding

We'll need to confirm whether goreleaser behaves differently if the workflow itself was not triggered from a tag. Likewise with homebrew.

EDIT: Asked about this in the goreleaser repo: goreleaser/goreleaser-action#492

Confirmed that this should be fine

jesseduffield · 2025-02-22T11:55:17Z

Assigning you as a reviewer @stefanhaller

jesseduffield · 2025-02-22T11:55:39Z

.github/workflows/release.yml


 on:
  schedule:
    # Runs at 2:00 AM UTC on the first Saturday of every month
-    - cron: '0 2 * * 6'
-  workflow_dispatch: # Allow manual triggering of the workflow
+    - cron: '0 2 1-7 * 6'


See https://crontab.guru/#0_2_1-7_*_6

Splitting this part out into a smaller PR in case the rest of this PR takes longer to merge: #4308

jesseduffield · 2025-02-22T11:59:30Z

.github/workflows/release.yml

+        with:
+          token: ${{secrets.GITHUB_API_TOKEN}}
+          formula: lazygit
+          tag: ${{env.new_tag}}


Passing the tag explicitly as per https://github.com/dawidd6/action-homebrew-bump-formula#standard-mode

It was previously on each saturday. Splitting this out from #4307 in case that takes longer to merge. - **PR Description** - **Please check if the PR fulfills these requirements** * [ ] Cheatsheets are up-to-date (run `go generate ./...`) * [ ] Code has been formatted (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#code-formatting)) * [ ] Tests have been added/updated (see [here](https://github.com/jesseduffield/lazygit/blob/master/pkg/integration/README.md) for the integration test guide) * [ ] Text is internationalised (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#internationalisation)) * [ ] If a new UserConfig entry was added, make sure it can be hot-reloaded (see [here](https://github.com/jesseduffield/lazygit/blob/master/docs/dev/Codebase_Guide.md#using-userconfig)) * [ ] Docs have been updated if necessary * [ ] You've read through your own file changes for silly mistakes etc

stefanhaller · 2025-02-22T18:49:57Z

Assigning you as a reviewer @stefanhaller

I'm super unfamiliar with all this stuff, I don't see how I could provide a review that's helpful in any way. I fully trust you that you know what you're doing. 😀

1) the cron schedule was wrong: it was doing every saturday, rather than the first saturday of each month. 2) It wasn't triggering a deploy despite pushing a tag because clearly github doesn't want that to happen. Now it triggers a deploy, and it also allows triggering from the UI, letting you specify minor/patch bump and whether to ignore blocking PRs/issues. As such I'm removing support for the old method of pushing the tag. The new way is the only way.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.47.1` -> `v0.47.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.47.2`](https://github.com/jesseduffield/lazygit/releases/tag/v0.47.2) [Compare Source](jesseduffield/lazygit@v0.47.1...v0.47.2)  Small patch release for you all. This is mainly to fix an issue with v0.47.1 which erroneously re-indented users' lazygit config files on startup. Shout-out to [@karimkhaleel](https://github.com/karimkhaleel) for his MR with some gnarly yaml-handling code. And a special shout-out to [@ChrisMcD1](https://github.com/ChrisMcD1) who has been pumping out many great contributions lately. Great to have you aboard. #### What's Changed ##### Enhancements 🔥 - Skip post-checkout hook when discarding changes by [@stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4313 ##### Fixes 🔧 - fix: Disable global keybinds when confirmation is active by [@ChrisMcD1](https://github.com/ChrisMcD1) in jesseduffield/lazygit#4284 - Don't rewrite config file unnecessarily when it contains commitPrefixes by [@ChrisMcD1](https://github.com/ChrisMcD1) in jesseduffield/lazygit#4311 - Change side panel width calculation to work for larger numbers by [@ChrisMcD1](https://github.com/ChrisMcD1) in jesseduffield/lazygit#4287 ##### Maintenance ⚙️ - Fix auto-release schedule by [@jesseduffield](https://github.com/jesseduffield) in jesseduffield/lazygit#4308 - Use indentation of 2 when rewriting auto-migrated config file by [@stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4312 - Use refs in jsonschema by [@karimkhaleel](https://github.com/karimkhaleel) in jesseduffield/lazygit#4309 - Improve release workflow by [@jesseduffield](https://github.com/jesseduffield) in jesseduffield/lazygit#4307 - Filter out dev comments from schema by [@stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4319 - Fix release script by [@jesseduffield](https://github.com/jesseduffield) in jesseduffield/lazygit#4322 - Fix release script once again by [@jesseduffield](https://github.com/jesseduffield) in jesseduffield/lazygit#4323 ##### Docs 📖 - Improve the error message when users have gpg signing turned on by [@stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4296 **Full Changelog**: jesseduffield/lazygit@v0.47.1...v0.47.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

jesseduffield force-pushed the improve-release-workflow branch from a8fef09 to fbb96ca Compare February 22, 2025 11:47

jesseduffield commented Feb 22, 2025

View reviewed changes

jesseduffield force-pushed the improve-release-workflow branch from fbb96ca to 680eacc Compare February 22, 2025 11:53

jesseduffield added the maintenance For refactorings, CI changes, tests, version bumping, etc label Feb 22, 2025

jesseduffield requested a review from stefanhaller February 22, 2025 11:55

jesseduffield commented Feb 22, 2025

View reviewed changes

jesseduffield force-pushed the improve-release-workflow branch from 680eacc to c448194 Compare February 22, 2025 11:59

jesseduffield commented Feb 22, 2025

View reviewed changes

jesseduffield mentioned this pull request Feb 22, 2025

Fix auto-release schedule #4308

Merged

7 tasks

jesseduffield force-pushed the improve-release-workflow branch from c448194 to fcf48c4 Compare February 23, 2025 20:18

jesseduffield merged commit e62aeb9 into master Feb 23, 2025
15 checks passed

jesseduffield deleted the improve-release-workflow branch February 23, 2025 20:34

jesseduffield mentioned this pull request Feb 25, 2025

lazygit 0.47.2 Homebrew/homebrew-core#208878

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve release workflow #4307

Improve release workflow #4307

jesseduffield commented Feb 22, 2025 •

edited

Loading

codacy-production bot commented Feb 22, 2025 •

edited

Loading

jesseduffield Feb 22, 2025

jesseduffield Feb 22, 2025 •

edited

Loading

jesseduffield Feb 23, 2025

jesseduffield commented Feb 22, 2025

jesseduffield Feb 22, 2025

jesseduffield Feb 22, 2025

jesseduffield Feb 22, 2025

stefanhaller commented Feb 22, 2025

Improve release workflow #4307

Improve release workflow #4307

Conversation

jesseduffield commented Feb 22, 2025 • edited Loading

codacy-production bot commented Feb 22, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

jesseduffield Feb 22, 2025

Choose a reason for hiding this comment

jesseduffield Feb 22, 2025 • edited Loading

Choose a reason for hiding this comment

jesseduffield Feb 23, 2025

Choose a reason for hiding this comment

jesseduffield commented Feb 22, 2025

jesseduffield Feb 22, 2025

Choose a reason for hiding this comment

jesseduffield Feb 22, 2025

Choose a reason for hiding this comment

jesseduffield Feb 22, 2025

Choose a reason for hiding this comment

stefanhaller commented Feb 22, 2025

jesseduffield commented Feb 22, 2025 •

edited

Loading

codacy-production bot commented Feb 22, 2025 •

edited

Loading

jesseduffield Feb 22, 2025 •

edited

Loading