Further update models #12
Conversation
There was a problem hiding this comment.
Many thanks! This looks mostly good to me :-)
For the future, could you please @mention me (by writing @jougs in the description of the PR or a comment somewhere) when you're doing these kinds of things? That way I'd be alerted by email when something is ready for me to look at without any need to communicate that via other means. Thanks!
models/ac_generator.h
Outdated
| @@ -46,7 +46,7 @@ ac_generator | |||
| Description | |||
| +++++++++++ | |||
|
|
|||
| This device produces an ac-current sent by a CurrentEvent. The | |||
| This device produces an AC current sent by a CurrentEvent. The | |||
There was a problem hiding this comment.
| This device produces an AC current sent by a CurrentEvent. The | |
| This device produces AC input sent by CurrentEvents. The |
Reasoning: AC already has a 'current' in it, cf. PIN number, LCD display, ...
models/bernoulli_connection.h
Outdated
| @@ -58,8 +58,8 @@ Parameters | |||
|
|
|||
| FirstVersion: June 2017 | |||
|
|
|||
| Transmits | |||
| +++++++++ | |||
| Sends | |||
There was a problem hiding this comment.
This needs to stay Transmits. Also in other files ending in _connection.h.
The logic is that neurons have the (single) event type they will send during the simulation under Sends and all event types they are able to handle under Receives. As synapses/connections only relay the events from the sender to the receiver, the have everything they can relay under Transmits.
models/dc_generator.h
Outdated
|
|
||
| Description | ||
| +++++++++++ | ||
|
|
||
| The DC-Generator provides a constant DC Input to the connected node. The unit of the current is pA. | ||
| The dc_generator provides a constant DC Input to the connected node. The unit of the current is pA. |
There was a problem hiding this comment.
| The dc_generator provides a constant DC Input to the connected node. The unit of the current is pA. | |
| The dc_generator provides a constant DC input to the connected node. The unit of the current is pA. |
|
@jougs Thanks for your suggestions! I added the RAS syndrome can be painful. Hence, I removed the repetitions. |
|
Great! Can you please again pull |
|
@jessica-mitchell: could you please merge this? I'm fine with the changes now. |
Incorporated requested changes.
Remove Vera++ checks and update clang-format to only version 9
Fix usage of write_upate_to_history()
This PR is based on nest#1374 and further updates the model files.
It:
ACandDC)Device nameEndUserDocsand the class definitioniaf_psc_exp_htum