chore: add eslint-plugin-eslint-plugin #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Feb 8, 2018
| expectNotToEqualCase(node, null) || expectNotToBeCase(node, null); | ||
| module.exports = { | ||
| meta: { | ||
| fixable: 'code', |
There was a problem hiding this comment.
Wee, awesome! This is a change I wanted to make, nice that this yells at us
There was a problem hiding this comment.
should probably make all of the rules be an object with a create function, even if they don't have any other properties
|
Feel free to send PR for |
SimenB
approved these changes
Feb 8, 2018
|
Thanks, I'll open a PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds eslint-plugin-eslint-plugin and its recommended configuration to this project's ESLint configuration. It has some useful rules for ESLint plugin codebases.
When adding the recommended configuration, there were three reports of this codebase violating the require-meta-fixable rule, which I have addressed in this PR.
In the future, I would like to include and fix the require-meta-docs-url rule as well, but I wanted to see if you were open to this addition to the codebase first.
It may be easier to append
?w=1to the URL in your browser when reviewing this PR (like this), which will show the diff with whitespace ignored.