Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AjaxMin 5.1 and YUICompressor.NET 2.3.0 #261

Open
AlexCuse opened this issue Oct 16, 2013 · 8 comments
Open

Support AjaxMin 5.1 and YUICompressor.NET 2.3.0 #261

AlexCuse opened this issue Oct 16, 2013 · 8 comments
Labels

Comments

@AlexCuse
Copy link
Collaborator

see title and #257

@kipusoep
Copy link

Shouldn't 0.9.5 get released by now? It's really too easy to upgrade AjaxMin via NuGet to version 5+ and find out SquishIt stops working...

@AlexCuse
Copy link
Collaborator Author

It's going to go out sometime this week. Just trying to resolve one last issue.

@kipusoep
Copy link

Awesome!

@AlexCuse
Copy link
Collaborator Author

@AlexCuse
Copy link
Collaborator Author

right down to the wire :)

@tobiasbunyan
Copy link

Forgive me if I am mistaken in something, but the NuGet dependencies for this still prevent updating when on YUICompressor 2.3?

YUICompressor.NET (= 2.0.0.0)
AjaxMin (≥ 4.48.4489.28432 && ≤ 4.97.4951.28483)

@kipusoep
Copy link

Yeah I noticed this too, while I'm already using SquishIt with YUICompressor.NET v2.3.0.0 succesfully.

@AlexCuse
Copy link
Collaborator Author

I could've sworn I tested 2.3 and something went wrong - maybe I other outstanding changes.

Anyway you're right, it works. I'm wary of removing the upper bound on YUI because v2 had breaking changes for us but I will increase the upper bound to 2.3. Support for AjaxMin 5+ will not be added until v1.0 though.

@AlexCuse AlexCuse mentioned this issue Jun 3, 2015
11 tasks
AlexCuse added a commit to AlexCuse/SquishIt that referenced this issue Aug 16, 2015
AlexCuse added a commit to AlexCuse/SquishIt that referenced this issue Aug 16, 2015
AlexCuse added a commit to AlexCuse/SquishIt that referenced this issue Dec 23, 2015
AlexCuse added a commit to AlexCuse/SquishIt that referenced this issue Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants