Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xray_repository_config resource showing updates when there are no… #310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amithins
Copy link

@amithins amithins commented Mar 7, 2025

… changes in resource for package type generic

shahiinn
shahiinn previously approved these changes Mar 7, 2025
@amithins amithins removed the request for review from vasukinjfrog March 7, 2025 07:05
@srinivasgowda097 srinivasgowda097 self-requested a review March 7, 2025 10:31
alexhung
alexhung previously approved these changes Mar 7, 2025
Copy link
Contributor

@alexhung alexhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. But where is the update to CHANGELOG?

@alexhung alexhung added the bug Something isn't working label Mar 7, 2025
@srinivasgowda097 srinivasgowda097 dismissed stale reviews from alexhung and shahiinn via ba67ce6 March 11, 2025 04:28
@srinivasgowda097 srinivasgowda097 force-pushed the fix-generic-repo-config-updates branch from 482f101 to ba67ce6 Compare March 11, 2025 04:28
@chukka chukka requested a review from a team March 11, 2025 05:10
shahiinn
shahiinn previously approved these changes Mar 12, 2025
@amithins amithins requested a review from alexhung March 12, 2025 08:41
oumkale
oumkale previously approved these changes Mar 12, 2025
… changes in resource for package type generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants