Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource_xray_operational_risk_policy support new operational ris… #311

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Fix resource_xray_operational_risk_policy support new operational ris… #311

merged 2 commits into from
Mar 14, 2025
+30 −18

Conversation

srinivasgowda097
Copy link
Collaborator

No description provided.

@srinivasgowda097 srinivasgowda097 requested a review from chukka as a code owner March 7, 2025 10:27
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 4d6c831 to 7d6c309 Compare March 7, 2025 10:42
shahiinn
shahiinn previously approved these changes Mar 7, 2025
View reviewed changes
alexhung
alexhung suggested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@alexhung alexhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-generate the doc so it reflects the change in code.

@alexhung
Copy link
Contributor

alexhung commented Mar 7, 2025

Also, there's no update to the CHANGELOG

@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 7d6c309 to 36aebbb Compare March 7, 2025 17:36
@srinivasgowda097
Copy link
Collaborator Author

Also, there's no update to the CHANGELOG

Updated

@srinivasgowda097
Copy link
Collaborator Author

Please re-generate the doc so it reflects the change in code.

Updated

alexhung
alexhung suggested changes Mar 7, 2025
View reviewed changes
@alexhung alexhung added the enhancement New feature or request label Mar 7, 2025
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 36aebbb to 545d639 Compare March 8, 2025 03:27
alexhung
alexhung previously approved these changes Mar 10, 2025
View reviewed changes
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 1195e99 to f1112ef Compare March 12, 2025 16:46
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from f1112ef to e0b688a Compare March 12, 2025 18:36
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from e0b688a to 79f175d Compare March 13, 2025 11:24
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 79f175d to 5a46a7f Compare March 13, 2025 13:01
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 5a46a7f to 9706c19 Compare March 13, 2025 16:26
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 9706c19 to 74dfebf Compare March 14, 2025 08:56
@srinivasgowda097 srinivasgowda097 force-pushed the fix-support-new-operational-risk-age-input branch from 74dfebf to 986cc9a Compare March 14, 2025 11:22
srinivasgowda097
srinivasgowda097 commented Mar 14, 2025
View reviewed changes
pkg/xray/resource/resource_xray_repository_config_test.go
@@ -454,14 +454,11 @@ func TestAccRepositoryConfig_RepoConfigCreate_no_exposure(t *testing.T) {
t.Skipf("Env var JFROG_JAS_DISABLED is set to 'true'")
}

packageTypes := []string{"alpine", "bower", "composer", "conan", "conda", "debian", "gems", "go", "gradle", "ivy", "rpm", "sbt"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages : alpine, debian, gems,go , gradle, rpm now Advanced JAS is supported with exposure

vasukinjfrog
vasukinjfrog approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@vasukinjfrog vasukinjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it as part of checking the acceptance tests verification

amithins
amithins approved these changes Mar 14, 2025
View reviewed changes
Copy link

@amithins amithins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasukinjfrog vasukinjfrog merged commit 7bb2e8e into main Mar 14, 2025
2 checks passed
@vasukinjfrog vasukinjfrog deleted the fix-support-new-operational-risk-age-input branch March 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhung alexhung alexhung left review comments

@amithins amithins amithins approved these changes

@vasukinjfrog vasukinjfrog vasukinjfrog approved these changes

@chukka chukka chukka left review comments

@oumkale oumkale Awaiting requested review from oumkale

@shahiinn shahiinn Awaiting requested review from shahiinn

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srinivasgowda097 @alexhung @chukka @amithins @shahiinn @vasukinjfrog @jfrogsolutioncicd