Left and top distance

[sherban1988]

Hey. Awesome AWESOME plugin. Really cool of you to take the time making it and sharing it with the world like this. Real simple to use too, and the added bonus of being able to use actual words and sentences? Genius!

Just thought you should know of a small issue. If the direction is selected as left or top, the distance isn't taken into account. It moves the same (24 px). I believe that can be seen in your demo as well.

Anyway, that's the only thing I can find wrong with it, so great job on your part.

[jlmakes]

Hey @sherban1988

Thanks for the kinds words. I’m glad you like it!

Thanks for catching this! (I thought this was fixed, see #13)

Now that you mention it, I see an issue with the code—I believe right here:

  //  After all values are parsed, let’s make sure our our
  //  pixel distance is negative for top and left entrances.
  //
  //  ie. "move 25px from top" starts at 'top: -25px' in CSS.

      if (enter == "top" || enter == "left") {
        if (!typeof parsed.move == "undefined") {
          parsed.move = "-" + parsed.move;
        }
        else {
          parsed.move = "-" + this.options.move;
        }
      }

I believe it’s the first if () block that’s incorrect — haha, not sure why I overcomplicated things; when I try:

      if (enter == "top" || enter == "left") {
        if (parsed.move) {
          parsed.move = "-" + parsed.move;
        }
        else {
          parsed.move = "-" + this.options.move;
        }
      }

It works as intended. I will push this change!