Update to the latest Vaadin 24.2 jmix-framework/jmix#2411 #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebfox
requested changes
Oct 31, 2023
| @@ -1,4 +1,4 @@ | |||
| // CAUTION: copied from @vaadin/tabsheet/theme/material/vaadin-tabsheet-style.js [since Vaadin 24.1.10] | |||
| // CAUTION: copied from @vaadin/tabsheet/theme/material/vaadin-tabsheet-style.js [since Vaadin 24.2.1] | |||
There was a problem hiding this comment.
Since Vaadin 24.2.1 looks incorrect. We copied a long time ago. Let's use last update Vaadin 24.2.1 as in the other "old" files.
glebfox
approved these changes
Oct 31, 2023
KremnevDmitry
deleted the
feature/2411-update-to-the-latest-vaadin-24-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jmix Framework issue: #2411
SB release notes: 3.1.5
Vaadin Release notes: 24.2.0, 24.2.1
New issues: #2413, #2414
The
flowui-devservermodule has been changed due to the following changes in Vaadin: vaadin/flow#17656