Disambiguate naturaldate return: only append year if more than ~5 months away #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Before
Previously,
naturaldate
appended the year if the input was more than about a year away (>= 365
days).That led to ambiguity:
And, assuming today is Feb 02 2020, the inputs on the left produced the outputs on the right:
After
Only append the year if the input is more than about 5 months away (
>= 5 * 30.5
days).