Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing strings for Polish translation #182

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Add missing strings for Polish translation #182

merged 1 commit into from
Oct 9, 2021

Conversation

kpostekk
Copy link
Contributor

As in title

@hugovk hugovk changed the title Add missing strings for polish translation Add missing strings for Polish translation Nov 17, 2020
@hugovk hugovk added the changelog: Added For new features label Nov 17, 2020
@hugovk
Copy link
Collaborator

hugovk commented Nov 17, 2020

Thank you!

Please could you run the "How to add new phrases to existing locale files" commands at https://github.com/jmoiron/humanize#localization (except for pl_PL not ru_RU) and update the PR?

@hugovk
Copy link
Collaborator

hugovk commented Nov 18, 2020

Please could you remove humanize.pot (it's in .gitignore) and also src/humanize/locale/pl_PL/LC_MESSAGES/humanize.po~?

Thanks!

hugovk
hugovk requested changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking PR as "requested changes"

@hugovk
Copy link
Collaborator

hugovk commented Oct 9, 2021

Thank you for the contribution!

@hugovk hugovk added the hacktoberfest-accepted To credit accepted Hacktoberfest PRs label Oct 9, 2021
@hugovk hugovk merged commit e926626 into jmoiron:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
changelog: Added For new features hacktoberfest-accepted To credit accepted Hacktoberfest PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpostekk @hugovk