Add Bengali langauage #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 9 9
Lines 632 632
=======================================
Hits 630 630
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
hugovk
requested changes
Jul 30, 2021
There was a problem hiding this comment.
Thanks for the PR! Please can you update these couple of things, and add the language to the README list? https://github.com/jmoiron/humanize#humanize
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
reviewed
Aug 1, 2021
|
okay I resolved all the issues |
hugovk
approved these changes
Aug 1, 2021
|
Thank you, released in 3.11.0! |
|
:) |
|
Wait I forgot to add the language to readme.md. oops |
|
No problem, I'll do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the language called Bengali which is spoken by Bengalis and 60 others according to google that mostly live in Bangladesh and Kolkata
The language is spoken by approximately 228 million native speakers and another 37 million as second-language speakers and ranks 7th among the most spoken languages in the world