Remove default indent #24
Conversation
|
Surely this is a breaking change? This was released with a patch version, but the change is to the output of this function; so if someone uses this library, will it not affect their tests? Feels like it should have been at-least 1.3.x not a continuation of 1.2.x |
|
@Lewiscowles1986 thanks for catching this. This PR was merged into master over 5 years ago and I didn't notice that it wasn't published to NPM. I'll get a new patch released that reverts this PR. |
|
😬 what about just releasing a major, or I contribute some docs about the breakage for a 1.2.5? My comment wasn't meant to do more than ignite discussion; I was not trying to tell what you should do; but I did get an update notification for this on a repo, and I read the changelog, and was curious. I was kinda hoping you'd tell me I read it wrong 😂 |
@Lewiscowles1986 you read it correctly and you're right that it's a breaking change. Since 1.2.4 is intentionally a patch to fix #32 , the default indent change should be in a new version. I get annoyed by patches having breaking changes, so I'm glad you caught that. I see you created a PR to re-add this change. Thanks for doing that and I'll try to get it merged and published soon. |
# [1.16.0](v1.15.0...v1.16.0) (2023-12-04) ### Upgrade * Bump word-wrap from 1.2.3 to 1.2.5 (#516) ([9c9251b](9c9251b)), closes [#516](#516) [jonschlinkert/word-wrap#24](jonschlinkert/word-wrap#24) [jonschlinkert/word-wrap#41](jonschlinkert/word-wrap#41) [jonschlinkert/word-wrap#33](jonschlinkert/word-wrap#33) [jonschlinkert/word-wrap#42](jonschlinkert/word-wrap#42) [jonschlinkert/word-wrap#24](jonschlinkert/word-wrap#24) [jonschlinkert/word-wrap#41](jonschlinkert/word-wrap#41) [jonschlinkert/word-wrap#33](jonschlinkert/word-wrap#33) [#42](#42) [#41](#41)
No description provided.