-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert compatibility #46
base: master
Are you sure you want to change the base?
Conversation
Thanks @lamweili . Should |
@doowb, |
@lamweili Thanks! Have the same issue with node v4 |
I'm having a problem with let on node 4 as well:
If I edit |
Although we might not use word-wrap explicitly, it is used by dependencies such as Editing the It will be good to quickly patch it back to restore compatibility instead of all dependencies changing major semver. |
Can confirm, I'm hitting this because of eslint. |
For clarification, I wasn’t suggesting editing index.js as a workaround. But if the maintainer wants to keep |
@doowb, any chance of merging and releasing it soon? |
It seems like @doowb is busy. How about @jonschlinkert? |
Bump! @doowb @jonschlinkert |
In commit 9f62693,
let
was used.word-wrap/index.js
Lines 9 to 10 in 207044e
However, the
package.json
specifies"node": ">=0.10.0"
compatibility.word-wrap/package.json
Line 28 in 207044e
This resulted in the following errors for older Node.js:
Thus, we should change
let
tovar
to maintain compatibility for^1.x.x
in adherence to semver.If compatibility needs to be upgraded, it should be the next major semver (
^2.x.x
) release.