Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hhvm ci task #16232

Merged
merged 2 commits into from
May 24, 2017
Merged

remove hhvm ci task #16232

merged 2 commits into from
May 24, 2017

Conversation

rdeutz
Copy link
Contributor

@rdeutz rdeutz commented May 24, 2017

Summary of Changes

It seems hhvm gets lower support from the PHP Community and with PHP7 there isn't really a need for it. So we are removing the ci task and with it any doubts if we support hhvm or not.

@brianteeman
Copy link
Contributor

Should we also state that hhvm is not supported on the requirements page

@rdeutz
Copy link
Contributor Author

rdeutz commented May 24, 2017

@brianteeman yes, if this is merged we should make our documentation consistent

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 16ab54f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16232.

@wilsonge
Copy link
Contributor

Do we state in the docs we do support it?

@rdeutz
Copy link
Contributor Author

rdeutz commented May 24, 2017

atm it doesn't say we are supporting it, but maybe we should say that we don't support it to make it crystal clear or saying if it runs fine but if not we don't care

@brianteeman
Copy link
Contributor

Its not like the mysql compatible databases which we dont explicitly say we support as hhvm is known to be different so we should explicitly state something like "not supported but may work"

My 20c

@brianteeman
Copy link
Contributor

For reference in the future if someone sees this and wonders why
http://symfony.com/blog/symfony-4-end-of-hhvm-support

@photodude
Copy link
Contributor

photodude commented May 26, 2017

in addition to passing our unit tests, we did have one user who did local testing on hhvm after the unit test were passing

Basically, Joomla CMS may work on HHVM but not supported. (kind of like mariaDB and other mysql variants)

There are 2 major reasons that Laravel, Symfony, Doctrine, CakePHP, MongoDB, PHPUnit, Composer, Twig, Silex, and Swiftmailer, etc have all dropped support for HHVM (that is something like 75% of the php market use has dropped support). 1) HHVM has needed to fix some big compatibility issues and 2) HHVM needs to improve their support when library devs report issues. With most of the big libraries moving to PHP7 only issues like HHVM and PHP7 differ on type annotations on internal functions (rtrim in particular) hhvm 7198 block the ability to test HHVM in HHVM's PHP7 mode since composer is unable to function due to that bug. Additionally, Cpanel and the like have never placed HHVM into the standard hosting options with PHP; resulting in limited user adoption with only places like Etsy on VMs or dedicated servers using HHVM. Add to that Travis testing of HHVM has tended to be outdated or slow and the new trusty container on travis is broken with mysql; testing is often the first step to support.

Personally, I hope that HHVM gets their act together so we and others can consider supporting HHVM again but at the moment it's a lame duck with little progress for those not programming with hiphop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants