Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stylesheet Mime type keeping b/c #16284

Merged
merged 7 commits into from
May 27, 2017
Merged

Fix Stylesheet Mime type keeping b/c #16284

merged 7 commits into from
May 27, 2017

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented May 26, 2017

Pull Request for Issue #16266.

Summary of Changes

Ensure b/c and ensure mime type is set on XML Stylesheets in RSS Feeds without PHP undefined index error.

Steps to replicate,

  • Edit /libraries/joomla/document/feed.php
  • On Line 206 (or anywhere in the render function, this is just to break it) add code:
// 3/4 style with no options or attribs
$this->addStyleSheet('/media/system/css/modal.css');

or

// 3 with mime specified
$this->addStyleSheet('/media/system/css/modal.css','text/css');

or

// Joomla 4 with type specified
$this->addStyleSheet('/media/system/css/modal.css',array(),array('type'=>'text/css'));
  • View any RSS feed created by your Joomla site (mine: E.g.: index.php?option=com_content&view=featured&Itemid=109&format=feed&type=rss)

  • see error message in the RSS of:

screen shot 2017-05-26 at 22 18 05

Then Apply this PR,

Expected result

No error

@810

@brianteeman
Copy link
Contributor

what change in 3.7 introduced this "error"? Surely we should be reviewing what broke things before coding solutions. Perhaps the thing thhat broke this broke something else as well which hasnt been reported yet

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@810
Copy link
Contributor

810 commented May 26, 2017

I have tested this item ✅ successfully on 3593f5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16284.

@810
Copy link
Contributor

810 commented May 26, 2017

We will change it before J4.

thnx for the fix

@PhilETaylor

This comment was marked as abuse.

@810
Copy link
Contributor

810 commented May 26, 2017

I have tested this item ✅ successfully on f6008d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16284.

1 similar comment
@ghost
Copy link

ghost commented May 27, 2017

I have tested this item ✅ successfully on f6008d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16284.

@ghost
Copy link

ghost commented May 27, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 27, 2017
Quy and others added 2 commits May 27, 2017 10:37
* Update article.xml

* addtional XML CS fixes

* part 2
@rdeutz rdeutz merged commit 4de0a46 into joomla:staging May 27, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 27, 2017
@rdeutz rdeutz added this to the Joomla 3.7.3 milestone May 27, 2017
izharaazmi added a commit to izharaazmi/joomla-cms that referenced this pull request May 31, 2017
* staging: (1779 commits)
  Deprecate modules correction (joomla#16362)
  Removed unnecessary code in com_content (joomla#14628)
  Stop installation if minimum requirement isn't met. (joomla#15890)
  Deprecate parts of com_modules (joomla#16152)
  LICENSE.txt (joomla#16317)
  [a11y] [com_fields] icons in modals (joomla#15047)
  Load jQuery in associations edit layout (joomla#16240)
  HHVM was removed. Remove from travis conditionals (joomla#16281)
  Fix Stylesheet Mime type keeping b/c (joomla#16284)
  re-merge joomla#15068 and joomla#16256
  Add showon attribute to add mailto link parameter (joomla#16282)
  Fix notices on Contact form (joomla#16279)
  Updating dutch TinyMCE files
  Media upload form margin (joomla#16253)
  Changes to display atom feeds correctly (joomla#16105)
  admin mod_latest (joomla#16277)
  Add truncate class and implement in popular articles module (joomla#16257)
  Using the "Special:MyLanguage" tag for links pointing to docs.joomla.org (joomla#15858)
  Change email notification to use site from address (Fix joomla#9261) (joomla#13518)
  Fix double encode ampersand in contact select list value (joomla#16268)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants