Some additional work on the adapter / compatibility with the last ember-data release #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringify the link object because ember-data expects a string / replace the Parse returned object with an empty array into the data of the relationship, because ember-data expects for nothing or an array of ids of records to retrieve
…hot" to be sync with the last ember-data specifications
… due to a bad read of the ember-data document example. Here, we do not create the attribute "attributes" into "json" object, we just delete the protected Parse keys
…hot" to be sync with the last ember-data specifications
…napshot.attr(key)" call due to an undefined function. So, keep the same logic into the overridden functions "createRecord" and "updateRecord" than in base class of ember-data, as the serializer works now with the snapshot (see ember-data-1.0.0-beta15 changelog).
… due to a bad read of the ember-data document example. Here, we do not create the attribute "attributes" into "json" object, we just delete the protected Parse keys
…To(key, { id: true }) logic to get the primary key
…ks" object was reinitialized at each iteration on the relations of the object, so only the last relation was correctly normalized with its link
…rue deserialized object
…to JSON to be correctly parse into findHasMany function
…g. when call store.find('person', {name: 'John'}) / updated tests
…tion represented by an empty array
|
Thanks Emilie! This looks great. I was starting to feel very alone with this adapter. It looks like this will make it fully compatible with ember-data-1.0.0-beta.15. You're awesome! |
joshfester
added a commit
that referenced
this pull request
Mar 4, 2015
Some additional work on the adapter / compatibility with the last ember-data release
|
Thank you. I'm glad if it could help ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I work on an Ember project that needs to communicate with the Parse background. I found this adapter, and saw that it was poorly maintained, until your last commits. Great job ! I made some additional work that might interest you. I tried to detail every changes into my comments to make it clear. I'm very busy with my project, but feel free if you have any question, I will do my best to answer you as quick as possible. Here are the main changes:
Thank you.
Emilie.