Enforce minimum merges when using match merging. #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing match merging. Below this threshold, merged matches are discarded.
tsaglam
added
enhancement
Kr0nox
requested changes
Feb 17, 2025
Kr0nox
approved these changes
Feb 18, 2025
tsaglam
changed the title
|
|
|
Details from the default value tests: Toggle me!
6 was chosen as a suitable default value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pairs of unrelated programs, match merging may increase the similarity as it is a heuristic-based approach to revert the effects of obfuscation. To reduce this effect on false positives, this PR introduces a threshold for the minimum number of merges. Below this threshold, the merged matches are discarded, and the original matches are used. Resolves #2077.
This PR includes: