pass JSON object to redisCacheModule #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpodwys
reviewed
Jan 29, 2018
| @@ -36,7 +36,9 @@ function redisCacheModule(config){ | |||
| self.backgroundRefreshIntervalCheck = (typeof config.backgroundRefreshIntervalCheck === 'boolean') ? config.backgroundRefreshIntervalCheck : true; | |||
| self.backgroundRefreshInterval = config.backgroundRefreshInterval || 60000; | |||
| self.backgroundRefreshMinTtl = config.backgroundRefreshMinTtl || 70000; | |||
| self.JSON = config.JSON || Object.create(JSON); | |||
There was a problem hiding this comment.
Could this just be self.JSON = config.JSON || JSON;?
There was a problem hiding this comment.
It can but it’s a bit error prone from what I experienced while writing the respective test case.
That’s because the JSON object is a global object and having redisCacheModule.JSON referencing it can lead to some inadvertent problems, e.g.: infinite recursion if the overrode method calls into the global method.
|
Thanks for this! It's looking good aside from my note on the PR. |
|
Published to NPM as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caching response containing a data property of type Buffer, the
JSON.stringifymethod will wrap the data property with{type: 'Buffer', data}(See node).The get from cache module will then parse it back to an generic object instead of a Buffer.
This fix allows the cache user to use a custom parser instead.