Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeFile options argument broken #28

Closed
sam-github opened this issue Jun 25, 2015 · 2 comments
Closed

writeFile options argument broken #28

sam-github opened this issue Jun 25, 2015 · 2 comments

Comments

@sam-github
Copy link

The docs are wrong:

https://github.com/jprichardson/node-jsonfile#writefilefilename-options-callback

they don't describe the data argument, I assume it should be writeFile(filename, obj, [options], callback)

Also, documented behaviour is

Pass in any fs.writeFile options

That includes the string, 'utf-8', but passing in a string was broken by:

e4d8e67
sam-github added a commit to strongloop/strong-arc that referenced this issue Jun 25, 2015
@sam-github
build-tasks: fix options to writeJsonFile
8bd63c2 
Work around jprichardson/node-jsonfile#28
@sam-github sam-github mentioned this issue Jun 25, 2015
Merged
@jprichardson
Copy link
Owner

Fixed in 44cf562 with more tests. Published in 2.2.1. Sorry about the trouble.

@sam-github
Copy link
Author

Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sam-github @jprichardson