Add globalObject: 'this' option to webpack config
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error `typeof window is not defined` in SSR
|
And some dependencies has same issue.
That packages also need same changes. |
|
Any update on this? Just ran into the referenced issue |
|
@jpuri any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error
typeof window is not definedin node env.It fixes #920 and #893
UMD module spec has
rootobject.Both node and browser have respective own root,
global,window. And we can access their root bythisin global execution context.So, this pr sets root object to
thisnotwindow.FYI: webpack/webpack#6642 (comment)