Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixin does not properly mix in toString #67

Closed
Sebmaster opened this issue Sep 6, 2017 · 1 comment · Fixed by #68
Closed

mixin does not properly mix in toString #67

Sebmaster opened this issue Sep 6, 2017 · 1 comment · Fixed by #68
Labels
bug

Comments

@Sebmaster
Copy link
Member

This currently impacts HTMLAnchorElement. The stringifier from HTMLHyperlinkElementUtils isn't properly mixed into it.
@Sebmaster Sebmaster added the bug label Sep 6, 2017
@Sebmaster Sebmaster mentioned this issue Sep 6, 2017
Merged
@TimothyGu
Copy link
Member

I'll take a look at this, presumably while also fixing #49.

TimothyGu added a commit to TimothyGu/webidl2js that referenced this issue Sep 6, 2017
@TimothyGu
Fix mixin generation
7889248 
Fixes jsdom#49.
Fixes jsdom#67.
TimothyGu added a commit to TimothyGu/webidl2js that referenced this issue Sep 6, 2017
@TimothyGu
Fix mixin generation
4f8bb60 
Fixes jsdom#49.
Fixes jsdom#67.
@TimothyGu TimothyGu mentioned this issue Sep 6, 2017
Merged
TimothyGu added a commit to TimothyGu/webidl2js that referenced this issue Sep 6, 2017
@TimothyGu
Fix mixin generation
1c33dfa 
Fixes jsdom#49.
Fixes jsdom#67.
TimothyGu added a commit to TimothyGu/webidl2js that referenced this issue Sep 10, 2017
@TimothyGu
Fix mixin generation
398c67c 
Fixes jsdom#49.
Fixes jsdom#67.
TimothyGu added a commit to TimothyGu/webidl2js that referenced this issue Sep 12, 2017
@TimothyGu
Fix mixin generation
41a0103 
Fixes jsdom#49.
Fixes jsdom#67.
TimothyGu added a commit that referenced this issue Sep 12, 2017
@TimothyGu
Fix mixin generation
bf9954d 
Fixes #49.
Fixes #67.
stevedorries pushed a commit to stevedorries/webidl2js that referenced this issue Jan 27, 2020
@saschanaz
BREAKING CHANGE: deprecate arrays and exceptions (jsdom#67)
8ec814b 
* remove array syntax

* remove array: false

* remove IDL exceptions

* docs: remove arrays and exceptions from readme

* Docs: use svg for high dpi screens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mixins, stringifiers, and static attributes TimothyGu/webidl2js
2 participants
@Sebmaster @TimothyGu