Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major update is not reflected in go.mod file #225

Closed
brlbil opened this issue May 10, 2024 · 1 comment · Fixed by #226
Closed

Major update is not reflected in go.mod file #225

brlbil opened this issue May 10, 2024 · 1 comment · Fixed by #226

Comments

@brlbil
Copy link
Contributor

brlbil commented May 10, 2024

Version 2 of the library is not usable right now because the module update is not reflected in the go.mod file as module github.com/jsimonetti/rtnetlink/v2
@SuperQ SuperQ mentioned this issue May 10, 2024
Merged
SuperQ added a commit to SuperQ/rtnetlink that referenced this issue May 10, 2024
@SuperQ
Fix Go mod path
4db5b29 
In order to update to v2.0.0, we need to update the module path per the
Go module documentation.
* https://go.dev/doc/modules/major-version

Fixes: jsimonetti#225

This can be released as v2.0.1

Signed-off-by: SuperQ <[email protected]>
@SuperQ
Copy link
Contributor

SuperQ commented May 10, 2024 •
edited
Loading

I just noticed this as well, opened PR to fix.

$ go get github.com/jsimonetti/[email protected]
go: github.com/jsimonetti/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/jsimonetti/rtnetlink/v2")

jsimonetti pushed a commit that referenced this issue May 10, 2024
@SuperQ
Fix Go mod path (#226)
8026e5d 
In order to update to v2.0.0, we need to update the module path per the
Go module documentation.
* https://go.dev/doc/modules/major-version

Fixes: #225

This can be released as v2.0.1

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Go mod path SuperQ/rtnetlink
2 participants
@SuperQ @brlbil