Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block zero analysis is likely to fail for small blocksz #22

Closed
jtmoon79 opened this issue Aug 14, 2022 · 1 comment
Closed

block zero analysis is likely to fail for small blocksz #22

jtmoon79 opened this issue Aug 14, 2022 · 1 comment
Labels
bug Something isn't working P1 important

Comments

@jtmoon79
Copy link
Owner

Problem

A small --blocksz, the smallest in release builds is 0x40, may cause failure during SyslogProcessor::blockzero_analysis_lines.

Solution

Refactor the blockzero_analysis_lines approach.

@jtmoon79 jtmoon79 added the bug Something isn't working label Aug 14, 2022
@jtmoon79 jtmoon79 added the P1 important label Dec 27, 2022
@jtmoon79
Copy link
Owner Author

jtmoon79 commented Jan 9, 2023

There is two connected issues that currently occur for any sized block:

jtmoon79 added a commit that referenced this issue Jan 16, 2023
For `find_line_in_block` when no `Line` is found, do return a
"partial" Line to the caller that is the from newline A to
end of the Block.
For `find_sysline_in_block` attempt to match a datetime on that
"partial" Line.
This is to allow matching long lines wihtin a blockzero analysis,
for long lines that extend into the next block (but those functions
will not look at). A "partial" means "looks very likely this
remaining data is a Line or Sysline".

Only used during blockzero analysis.

Issue #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 important
Projects
None yet
Development

No branches or pull requests

1 participant