-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fish] Enable multiple history commands insertion #4280
Conversation
Thanks, I think this is very nice. I didn't do it in other shells, only because it was difficult to get it right. |
Could you clarify which temporary files you mean? I wonder if it's a bug of fzf. |
1a1f294
to
857143d
Compare
The Lines 4919 to 4922 in e4489dc
|
Enable inserting multiple history commands. To disable, set `--no-multi` through `$FZF_CTRL_R_OPTS`. Also, remove the usage of `become` action, to avoid leaving behind temporary files.
857143d
to
751ace0
Compare
Thanks! Merged with a test case. |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [junegunn/fzf](https://github.com/junegunn/fzf) | patch | `v0.60.2` -> `v0.60.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.60.3`](https://github.com/junegunn/fzf/releases/tag/v0.60.3): 0.60.3 [Compare Source](junegunn/fzf@v0.60.2...v0.60.3) - Bug fixes and improvements - \[fish] Enable multiple history commands insertion ([#​4280](junegunn/fzf#4280)) ([@​bitraid](https://github.com/bitraid)) - \[walker] Append '/' to directory entries on MSYS2 ([#​4281](junegunn/fzf#4281)) - Trim trailing whitespaces after processing ANSI sequences ([#​4282](junegunn/fzf#4282)) - Remove temp files before `become` when using `--tmux` option ([#​4283](junegunn/fzf#4283)) - Fix condition for using item numlines cache ([#​4285](junegunn/fzf#4285)) ([@​alex-huff](https://github.com/alex-huff)) - Make `--accept-nth` compatible with `--select-1` ([#​4287](junegunn/fzf#4287)) - Increase the query length limit from 300 to 1000 ([#​4292](junegunn/fzf#4292)) - \[windows] Prevent fzf from consuming user input while paused ([#​4260](junegunn/fzf#4260)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
I recently realized that the
become
action leaves behind temporary files, so I made some modifications to overcome this. While doing so, I thought it would be a good idea to allow inserting multiple commands when--multi
is set. If for some reason you don't like this, I can remove this functionality and just adjust the code to not usebecome
. If on the other hand you think that it should be enabled by default, I can make this change, too. Tested to work with the oldest supported fish version.