dump timezone and offset for junit reporter xml timestamp

[graingert]

Overview

related to pytest-dev/pytest#7662

It looks like pytest (and Junit) just takes the system time from OS, and save it to test report.
Unfortunately, this timestamp doesn't have any timezone information, Our CI system will treat this timestamp as a UTC time, even the timestamp is actually from another time zone.

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes
• All continuous integration builds pass

[sbrannen]

Can you please provide a rationale for the proposed change?

[graingert]

@sbrannen updated

[sbrannen]

Note that your PR breaks the build with failing tests.

Before submitting a PR, please make sure you execute ./gradlew build locally.

[marcphilipp]

Is passing -Duser.timezone=UTC to the test JVM a viable workaround?

[codecov]

Codecov Report

Merging #2388 into main will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2388      +/-   ##
============================================
- Coverage     89.86%   89.85%   -0.01%     
- Complexity     4544     4545       +1     
============================================
  Files           397      397              
  Lines         11238    11239       +1     
  Branches        909      909              
============================================
  Hits          10099    10099              
  Misses          863      863              
- Partials        276      277       +1     

Impacted Files	Coverage Δ	Complexity Δ
...g/junit/platform/engine/reporting/ReportEntry.java	100.00% <100.00%> (ø)	8.00 <1.00> (+1.00)
...platform/reporting/legacy/xml/XmlReportWriter.java	96.53% <100.00%> (ø)	56.00 <1.00> (ø)
...jupiter/engine/execution/ExtensionValuesStore.java	89.70% <0.00%> (-1.48%)	21.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4688072...c55a378. Read the comment docs.

[marcphilipp]

❓ That's the format you want in the XML? Could you please double check that tools that read this XML report, e.g. Jenkins, don't choke on this?

[graingert]

Yep going to do the same for pytest too pytest-dev/pytest#7662 (comment)

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be closed if no further activity occurs. If you intend to work on this pull request, please reopen the PR. Thank you for your contributions.

[stale]

This pull request has been automatically closed due to inactivity. If you are still interested in contributing this, please ensure that it is rebased against the latest branch (usually main), all review comments have been addressed and the build is passing.