Skip to content

Commit 0a86f7c

Browse files
committed
fail validation if validate returns False
ExtensionPoint.validate returns False when any error is raised ListServerExtension does not check the return value, only errors
1 parent 87298c9 commit 0a86f7c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

jupyter_server/extension/serverextension.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,8 @@ def list_server_extensions(self):
306306
GREEN_ENABLED if enabled else RED_DISABLED))
307307
try:
308308
self.log.info(" - Validating {}...".format(name))
309-
extension.validate()
309+
if not extension.validate():
310+
raise ValueError("validation failed")
310311
version = extension.version
311312
self.log.info(
312313
" {} {} {}".format(name, version, GREEN_OK)

0 commit comments

Comments
 (0)