Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docs build and typing #1168

Merged
merged 6 commits into from
Jan 12, 2023

Conversation

blink1073
Copy link
Contributor

Fixes #1125

  • Inlines autogen_api.py to avoid all the path shenanigans.
  • Cleans up usage of version in conf.py.
  • Cleans up type ignores (relies on forthcoming releases of jupyter_server and jupyter_server_terminals

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 75.67% // Head: 80.06% // Increases project coverage by +4.38% 🎉

Coverage data is based on head (8bd3910) compared to base (3d516b3).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   75.67%   80.06%   +4.38%     
==========================================
  Files          68       68              
  Lines        8149     8150       +1     
  Branches     1605     1605              
==========================================
+ Hits         6167     6525     +358     
+ Misses       1543     1197     -346     
+ Partials      439      428      -11     
Impacted Files Coverage Δ
jupyter_server/services/sessions/sessionmanager.py 88.36% <0.00%> (ø)
jupyter_server/gateway/managers.py 83.37% <100.00%> (ø)
jupyter_server/services/events/handlers.py 87.93% <100.00%> (ø)
jupyter_server/terminal/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
jupyter_server/terminal/api_handlers.py 100.00% <100.00%> (+100.00%) ⬆️
jupyter_server/terminal/terminalmanager.py 100.00% <100.00%> (+100.00%) ⬆️
jupyter_server/utils.py 85.46% <100.00%> (+30.23%) ⬆️
jupyter_server/services/sessions/handlers.py 79.20% <0.00%> (+0.79%) ⬆️
jupyter_server/auth/identity.py 86.09% <0.00%> (+1.32%) ⬆️
jupyter_server/base/handlers.py 78.82% <0.00%> (+1.76%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 enabled auto-merge (squash) January 10, 2023 14:57
@vidartf
Copy link
Member

vidartf commented Jan 11, 2023

Some type errors on your main merge :)

@blink1073
Copy link
Contributor Author

Yeah, it looks like our terminals shim is referencing things that do not exist in jupyter_server_terminals, I need to sort this out.

@blink1073 blink1073 merged commit 5cce2af into jupyter-server:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.1: documentation uses pkg_resources
2 participants