Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repr in logging for exception. #1185

Merged
merged 1 commit into from
Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jupyter_server/extension/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,9 @@ def load_extension(self, name):
except Exception as e:
if self.serverapp and self.serverapp.reraise_server_extension_failures:
raise
self.log.warning("%s | extension failed loading with message: %s", name, e)
self.log.exception("%s | stack trace", name)
self.log.warning(
"%s | extension failed loading with message: %r", name, e, exc_info=True
)
else:
self.log.info("%s | extension was successfully loaded.", name)

Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/nbconvert/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ async def get(self, format, path):
lambda: exporter.from_notebook_node(nb, resources=resource_dict)
)
except Exception as e:
self.log.exception("nbconvert failed: %s", e)
self.log.exception("nbconvert failed: %r", e)
raise web.HTTPError(500, "nbconvert failed: %s" % e) from e

if respond_zip(self, name, output, resources):
Expand Down
4 changes: 2 additions & 2 deletions jupyter_server/serverapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -2618,7 +2618,7 @@ def write_server_info_file(self):
with secure_write(self.info_file) as f:
json.dump(self.server_info(), f, indent=2, sort_keys=True)
except OSError as e:
self.log.error(_i18n("Failed to write server-info to %s: %s"), self.info_file, e)
self.log.error(_i18n("Failed to write server-info to %s: %r"), self.info_file, e)

def remove_server_info_file(self):
"""Remove the jpserver-<pid>.json file created for this server.
Expand Down Expand Up @@ -2760,7 +2760,7 @@ def launch_browser(self):
try:
browser = webbrowser.get(self.browser or None)
except webbrowser.Error as e:
self.log.warning(_i18n("No web browser found: %s.") % e)
self.log.warning(_i18n("No web browser found: %r.") % e)
browser = None

if not browser:
Expand Down
8 changes: 4 additions & 4 deletions jupyter_server/services/contents/filemanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def _dir_model(self, path, content=True):
try:
os_path = os.path.join(os_dir, name)
except UnicodeDecodeError as e:
self.log.warning("failed to decode filename '%s': %s", name, e)
self.log.warning("failed to decode filename '%s': %r", name, e)
continue

try:
Expand All @@ -297,7 +297,7 @@ def _dir_model(self, path, content=True):
if e.errno == errno.ENOENT:
self.log.warning("%s doesn't exist", os_path)
elif e.errno != errno.EACCES: # Don't provide clues about protected files
self.log.warning("Error stat-ing %s: %s", os_path, e)
self.log.warning("Error stat-ing %s: %r", os_path, e)
continue

if (
Expand Down Expand Up @@ -636,7 +636,7 @@ async def _dir_model(self, path, content=True):
try:
os_path = os.path.join(os_dir, name)
except UnicodeDecodeError as e:
self.log.warning("failed to decode filename '%s': %s", name, e)
self.log.warning("failed to decode filename '%s': %r", name, e)
continue

try:
Expand All @@ -646,7 +646,7 @@ async def _dir_model(self, path, content=True):
if e.errno == errno.ENOENT:
self.log.warning("%s doesn't exist", os_path)
elif e.errno != errno.EACCES: # Don't provide clues about protected files
self.log.warning("Error stat-ing %s: %s", os_path, e)
self.log.warning("Error stat-ing %s: %r", os_path, e)
continue

if (
Expand Down