-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify ChannelQueue that the response router thread is finishing #896
Notify ChannelQueue that the response router thread is finishing #896
Conversation
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
==========================================
+ Coverage 70.52% 71.44% +0.92%
==========================================
Files 65 65
Lines 7698 7705 +7
Branches 1287 1289 +2
==========================================
+ Hits 5429 5505 +76
+ Misses 1879 1805 -74
- Partials 390 395 +5
Continue to review full report at Codecov.
|
…uments to super(GatewayKernelClient).__init__(kernel_id='88a220ed-870d-4bbf-86b0-f29921ff0e2d')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CiprianAnton - these changes look good - thank you. Tested the changes via elyra/papermill/nbclient using a k8s-enabled enterprise gateway.
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…yter-server#896) (cherry picked from commit ee40dbc)
… router thread is finishing) (#897) Co-authored-by: Ciprian Anton <[email protected]>
In case the
response_router
encounters an error, the thread will exit and there is no code to check if it's still alive. This would mean waiting for messages that never arrives.Added a simple flag based notification mechanism where the route_responses will notify channels that the thread is exiting.
Also because the route_responses thread depends on channels to be created, it is important to make sure we don't start this thread before starting channels.