Setting to disable redirect file browser launch #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it was originally added, the PR for launching a browser via a redirect file (#4260) created some issues for some environments-namely WSL, Chromebook, and Android (#4346 (comment), jupyter/help#496). The reason for the break in these environments is due to the file structure/path differences between the runtime and the browser. This commit adds a setting to the `jupyter_notebook_config.py` that allows users to disable the use of redirect file for launching a browser in favor of the original, yet visible, URL + token approach. This setting: `c.NotebookApp.use_redirect_file` will be set to True by default.
|
@takluyver, this PR solves #4346 as well |
takluyver
reviewed
Oct 29, 2019
Makes the necessary changes proposed by @takluyver in #4999
betteridiot
commented
Oct 29, 2019
notebook/notebookapp.py
Outdated
Comment on lines
652
to
663
| For versions of notebook > 5.7.2, a security feature measure was added that | ||
| prevented the authentication token used to launch the browser from being visible. | ||
| This feature makes it difficult for other users on a multi-user system from | ||
| running code in your Jupyter session as you. | ||
|
|
||
| However, some environments (like Windows Subsystem for Linux (WSL) and Chromebooks), | ||
| launching a browser using a redirect file can lead the browser failing to load. | ||
| This is because of the difference in file structures/paths between the runtime and | ||
| the browser. | ||
|
|
||
| Disabling this setting will by setting to False will disable this behavior, | ||
| allowing the browser to launch by using a URL and visible token (as before). | ||
| Disabling this setting to False will disable this behavior, allowing the browser | ||
| to launch by using a URL and visible token (as before). |
There was a problem hiding this comment.
Changed language regarding the security risk if the setting is disabled
betteridiot
commented
Oct 29, 2019
|
I believe these changes address all of your review notes @takluyver |
takluyver
reviewed
Oct 30, 2019
As per the comments in #4999 (comment), the setting was removed.
|
Thanks :-) |
|
No. Thank you! Any input as to the release schedule to conda-forge on this? |
|
@lresende has done the last couple of releases - I'll let him answer about if/when he's planning another one. |
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it was originally added, the PR for launching a browser via a redirect file (#4260) created some issues for some environments-namely WSL, Chromebook, and Android (#4346 (comment), jupyter/help#496). The reason for the break in these environments is due to the file structure/path differences between the runtime and the browser.
This commit adds a setting to the
jupyter_notebook_config.pythat allows users to disable the use of redirect file for launching a browser in favor of the original, yet visible, URL + token approach. This setting:c.NotebookApp.use_redirect_filewill be set to True by default.