Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles /clear command with selection #307

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

JasonWeill
Copy link
Collaborator

Fixes #295. Handles /clear (and other commands) followed by a newline, not just a space, by splitting the input on any whitespace. This makes it so that /clear followed by two newlines and a code block (as is sent when "Include selection" is checked) is properly interpreted as a command, not as a message to the language model.

This should be backported to 1.x.

@JasonWeill JasonWeill added bug Bugs reported by users scope:chat-ux Issues concerning the chat user experience labels Jul 31, 2023
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great catch.

@JasonWeill JasonWeill merged commit bbe244a into jupyterlab:main Aug 1, 2023
JasonWeill added a commit to JasonWeill/jupyter-ai that referenced this pull request Aug 1, 2023
@JasonWeill JasonWeill mentioned this pull request Aug 1, 2023
JasonWeill added a commit that referenced this pull request Aug 1, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs reported by users scope:chat-ux Issues concerning the chat user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/clear command does not clear left pane if "Include selection" is selected
2 participants