Apply renaming suggestion

jupyterlab · Feb 17, 2025 · bce2322 · bce2322
1 parent 0ec3b75
commit bce2322
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/jupyter-chat/src/components/chat-input.tsx b/packages/jupyter-chat/src/components/chat-input.tsx
@@ -69,12 +69,12 @@ export function ChatInput(props: ChatInput.IProps): JSX.Element {
     const attachmentChanged = (_: IChatModel, attachments: IAttachment[]) => {
       setAttachments([...attachments]);
     };
-    model.inputAttachmentsChanges?.connect(attachmentChanged);
+    model.inputAttachmentsChanged?.connect(attachmentChanged);
 
     return () => {
       model.configChanged?.disconnect(configChanged);
       model.focusInputSignal?.disconnect(focusInputElement);
-      model.inputAttachmentsChanges?.disconnect(attachmentChanged);
+      model.inputAttachmentsChanged?.disconnect(attachmentChanged);
     };
   }, [model]);
 

diff --git a/packages/jupyter-chat/src/model.ts b/packages/jupyter-chat/src/model.ts
@@ -95,7 +95,7 @@ export interface IChatModel extends IDisposable {
   /**
    * A signal emitting when the input attachments changed.
    */
-  readonly inputAttachmentsChanges?: ISignal<IChatModel, IAttachment[]>;
+  readonly inputAttachmentsChanged?: ISignal<IChatModel, IAttachment[]>;
 
   /**
    * Send a message, to be defined depending on the chosen technology.
@@ -417,8 +417,8 @@ export class ChatModel implements IChatModel {
   /**
    * A signal emitting when the input attachments changed.
    */
-  get inputAttachmentsChanges(): ISignal<IChatModel, IAttachment[]> {
-    return this._inputAttachmentsChanges;
+  get inputAttachmentsChanged(): ISignal<IChatModel, IAttachment[]> {
+    return this._inputAttachmentsChanged;
   }
 
   /**
@@ -560,7 +560,7 @@ export class ChatModel implements IChatModel {
     }
 
     this.inputAttachments.push(attachment);
-    this._inputAttachmentsChanges.emit([...this.inputAttachments]);
+    this._inputAttachmentsChanged.emit([...this.inputAttachments]);
   };
 
   /**
@@ -575,15 +575,15 @@ export class ChatModel implements IChatModel {
     }
 
     this.inputAttachments.splice(attachmentIndex, 1);
-    this._inputAttachmentsChanges.emit([...this.inputAttachments]);
+    this._inputAttachmentsChanged.emit([...this.inputAttachments]);
   };
 
   /**
    * Update attachments.
    */
   clearAttachments = (): void => {
     this.inputAttachments = [];
-    this._inputAttachmentsChanges.emit([]);
+    this._inputAttachmentsChanged.emit([]);
   };
 
   /**
@@ -653,7 +653,7 @@ export class ChatModel implements IChatModel {
   private _viewportChanged = new Signal<IChatModel, number[]>(this);
   private _writersChanged = new Signal<IChatModel, IUser[]>(this);
   private _focusInputSignal = new Signal<ChatModel, void>(this);
-  private _inputAttachmentsChanges = new Signal<ChatModel, IAttachment[]>(this);
+  private _inputAttachmentsChanged = new Signal<ChatModel, IAttachment[]>(this);
 }
 
 /**