Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call chdir to run server #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dolfinus
Copy link

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read and understand the [Code of Conduct][code-of-conduct].
  • Read and understood the [licensing terms][license].
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Submitted against master branch.

Description

What is the purpose of this pull request?

This pull request:

  • Replaces executing chdir with just passing an extension folder as an argument for uvicorn script.

Related Issues

Does this pull request have any related issues?

This pull request:

  • I've faced a new issue: every new terminal window in the running notebook is opening in the jupyterlab_commenting extension folder. Now it's fixed.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@dolfinus
Copy link
Author

TS tests are not running but this is not related to changes I've made.

@dolfinus
Copy link
Author

dolfinus commented Mar 1, 2021

@saulshanabrook Could you please take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant