Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add preferred dir option to config #190

Merged

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jul 21, 2021

Following on the discussion of adding a new trait preferred-dir

And the PR on JServer -> jupyter-server/jupyter_server#549

This PR now exposes that option on the page config. I added both the full url and the relative path to use if found in the frontend which is using it over at jupyterlab/jupyterlab#10667

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #190 (17e17d7) into master (3c7a83c) will decrease coverage by 0.12%.
The diff coverage is 85.71%.

❗ Current head 17e17d7 differs from pull request most recent head 894e0da. Consider uploading reports for the commit 894e0da to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   78.70%   78.58%   -0.13%     
==========================================
  Files          27       27              
  Lines        2010     2003       -7     
==========================================
- Hits         1582     1574       -8     
- Misses        428      429       +1     
Impacted Files Coverage Δ
jupyterlab_server/handlers.py 89.10% <85.71%> (-0.16%) ⬇️
jupyterlab_server/settings_handler.py 85.18% <0.00%> (-0.27%) ⬇️
jupyterlab_server/tests/test_settings_api.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7a83c...894e0da. Read the comment docs.

@goanpeca goanpeca force-pushed the enh/add-preferred-dir-to-page-config branch from 44b888d to dad5073 Compare July 21, 2021 21:45
@goanpeca goanpeca changed the title WIP: Add preferred dir option to config PR: Add preferred dir option to config Jul 21, 2021
@goanpeca goanpeca force-pushed the enh/add-preferred-dir-to-page-config branch from a5e5bdb to 17e17d7 Compare July 21, 2021 21:50
@goanpeca goanpeca force-pushed the enh/add-preferred-dir-to-page-config branch from 17e17d7 to 894e0da Compare July 21, 2021 21:53
@goanpeca goanpeca marked this pull request as ready for review July 21, 2021 21:56
@goanpeca goanpeca requested a review from blink1073 July 21, 2021 21:58
@goanpeca goanpeca self-assigned this Jul 21, 2021
@goanpeca goanpeca requested a review from echarles July 21, 2021 21:58
@blink1073 blink1073 added this to the 2.6 milestone Jul 22, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 4cd881e into jupyterlab:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants