This repository was archived by the owner on Jun 7, 2022. It is now read-only.
Update dependencies #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,7 +105,7 @@ fn find_definition_request_from_json() { | |||
| assert_eq!(req.column, 3); | |||
| } | |||
|
|
|||
| #[derive(Debug, Deserialize, Serialize)] | |||
| #[derive(Debug, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
Is the order important? I don't think I would ever have thought of that!
There was a problem hiding this comment.
It doesn't actually matter. This was an attempt to fix a weird error that turned out to be due to an old version of serde_codegen. I'll revert this line.
There was a problem hiding this comment.
Ok, thanks for explaining!
Some dependencies don't guarantee beta compatibility making it difficult for racerd to do so. In this case, the latest version of clap (racer dep) is broken.
|
I filed contain-rs/vec-map#22 about the vec_map issue. |
|
Thanks! I wonder if that was a bug in beta? Current nightly doesn't seem to have that issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50, #48, #45.
This change is