Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video and Sound not matching! #1269

Closed
Pete4K opened this issue Dec 21, 2024 · 21 comments
Closed

Video and Sound not matching! #1269

Pete4K opened this issue Dec 21, 2024 · 21 comments
Labels
state:Done This issue has been resolved/dismissed type:Bug Something isn't working

Comments

@Pete4K
Copy link

Pete4K commented Dec 21, 2024

Every video's sound is not matching anymore using Real ESRGAN. Before it was matching with the standard setting every time.

@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Dec 21, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

Any chance you send me a video so I can test it?

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

I try so send some test here. One moment.

@k4yt3x k4yt3x added type:Bug Something isn't working state:InProgress This issue is being worked on and removed state:Backlog This issue will be worked on in the future labels Dec 21, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

It should be related to this:

Fixed: Make the encoder always use the calculated PTS with corrected math.

The math works out for the videos I tested with. My tests probably didn't cover all the cases.

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

Dan.Da.Dan.S01e12.German.Realesrgan.mp4

Here you can see at 0:33 and so on. The difference between audio and video gets bigger and bigger. I made the file very small.

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

The basic file works normally. Everything I tried was like this clip above.

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

Hmm I think it's probably my integer math losing precision as time increases. This might fix it:

image

Can you send me the original video so I can test it?

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

Via Google Drive, https://wormhole.app or something

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

Try it, I think I should delete this immediately after

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

It's taking forever to download. I'm guessing you're still uploading as I download. I'll leave it running for now. Once I finish download I'll delete the file.

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

For me it is uploaded now. How long does it still run for you?

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

It got stuck for a long time so I used another browser which finished downloading in seconds. I just finished downloading and deleted the share.

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

Ok, thanks.

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

I think my patch fixed it. Take a look:
https://wormhole.app/802a7#-3k0W8gUgnOXlSosW0ewTg

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

Yes, it works! Definitely matching now!

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

Nice. I'll see if there's anything else that needs to be changed, and I'll launch a patch 6.3.1 within today. I'll close this issue when it's merged to master branch. You can lookout for a new release in a few hours.

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

Ok, thank you very much. I have still a question: When I use Real ESRGAN and I use a 720p File and convert it to 4K (around 6,2 FPS) it is faster than I use a 1080p File and convert it to 4K (around 4,2 FPS). Is that normal? I would think that a 1080p File should have a faster framerate. And when I make 720p --> 2160p the file gets bigger than 1080p --> 2160p. Could that be an another bug?

@k4yt3x
Copy link
Owner

k4yt3x commented Dec 21, 2024

What affects the speed the most for ML models it the input image size. Having a smaller input dimension will be faster to process, no matter what the output size is.

And when I make 720p --> 2160p the file gets bigger than 1080p --> 2160p.

This is not a bug. It's handled by the encoder, not Video2X.

@Pete4K
Copy link
Author

Pete4K commented Dec 21, 2024

OK

@k4yt3x k4yt3x closed this as completed Dec 21, 2024
@github-actions github-actions bot added state:Done This issue has been resolved/dismissed and removed state:InProgress This issue is being worked on labels Dec 21, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Dec 22, 2024

@Pete4K just giving you a ping. 6.3.1 is out with the patch.

@Pete4K
Copy link
Author

Pete4K commented Dec 22, 2024

Thank you very much for your fast solving of the issue! I try it in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:Done This issue has been resolved/dismissed type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants