-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video and Sound not matching! #1269
Comments
Any chance you send me a video so I can test it? |
I try so send some test here. One moment. |
It should be related to this:
The math works out for the videos I tested with. My tests probably didn't cover all the cases. |
Dan.Da.Dan.S01e12.German.Realesrgan.mp4Here you can see at 0:33 and so on. The difference between audio and video gets bigger and bigger. I made the file very small. |
The basic file works normally. Everything I tried was like this clip above. |
Via Google Drive, https://wormhole.app or something |
Try it, I think I should delete this immediately after |
It's taking forever to download. I'm guessing you're still uploading as I download. I'll leave it running for now. Once I finish download I'll delete the file. |
For me it is uploaded now. How long does it still run for you? |
It got stuck for a long time so I used another browser which finished downloading in seconds. I just finished downloading and deleted the share. |
Ok, thanks. |
I think my patch fixed it. Take a look: |
Yes, it works! Definitely matching now! |
Nice. I'll see if there's anything else that needs to be changed, and I'll launch a patch 6.3.1 within today. I'll close this issue when it's merged to master branch. You can lookout for a new release in a few hours. |
Ok, thank you very much. I have still a question: When I use Real ESRGAN and I use a 720p File and convert it to 4K (around 6,2 FPS) it is faster than I use a 1080p File and convert it to 4K (around 4,2 FPS). Is that normal? I would think that a 1080p File should have a faster framerate. And when I make 720p --> 2160p the file gets bigger than 1080p --> 2160p. Could that be an another bug? |
What affects the speed the most for ML models it the input image size. Having a smaller input dimension will be faster to process, no matter what the output size is.
This is not a bug. It's handled by the encoder, not Video2X. |
OK |
…#1269) Signed-off-by: k4yt3x <[email protected]>
@Pete4K just giving you a ping. 6.3.1 is out with the patch. |
Thank you very much for your fast solving of the issue! I try it in a few hours. |
Every video's sound is not matching anymore using Real ESRGAN. Before it was matching with the standard setting every time.
The text was updated successfully, but these errors were encountered: