-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBAC: Make it possible to use regex for values #663
base: main
Are you sure you want to change the base?
RBAC: Make it possible to use regex for values #663
Conversation
Hey ! Any chance to see this PR merged ? |
sorry, will take a look this week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for covering this with tests, that's really helpful!
Left a few minor inline comments
api/src/main/java/io/kafbat/ui/service/rbac/extractor/CognitoAuthorityExtractor.java
Outdated
Show resolved
Hide resolved
api/src/test/java/io/kafbat/ui/config/RegexBasedProviderAuthorityExtractorTest.java
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/service/rbac/extractor/OauthAuthorityExtractor.java
Outdated
Show resolved
Hide resolved
hey @Haarolean , is it possible for you to give a look again ? many thanks |
@callaertanthony thank you! If you have time, could you update our docs as well? https://github.com/kafbat/ui-docs |
@Haarolean , by updating the documentation I tell myself that we are introducing a (security) breaking change. - provider: oauth_google
type: domain
value: "memelord.lol" So, if starting from now we evaluate the subject as regex, user is not directly impacted, because I see two options :
What do we do ? |
@callaertanthony hey, good point! We've discussed this: we believe a better approach would be introducing a new boolean param like |
thanks @Haarolean , @francoisvandenplas I created this pr with the change : francoisvandenplas#1 |
could you rebase this branch instead please? |
api/src/main/java/io/kafbat/ui/service/rbac/extractor/OauthAuthorityExtractor.java
Show resolved
Hide resolved
Hello, |
What changes did you make? (Give an overview)
Rbac now handle regex in values
Fixes #300
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)