Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Allow overriding producer and consumer properties #874

Merged
merged 3 commits into from
Mar 8, 2025

Conversation

wernerdv
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves #527

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner February 27, 2025 19:30
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 27, 2025
@wernerdv
Copy link
Contributor Author

@Haarolean Please review this PR when you get a chance. Thanks!

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Feb 28, 2025
@Haarolean Haarolean added this to the 1.2 milestone Feb 28, 2025
Copy link
Member

@germanosin germanosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haarolean Haarolean enabled auto-merge (squash) March 8, 2025 08:58
@Haarolean Haarolean merged commit d91483b into kafbat:main Mar 8, 2025
13 of 15 checks passed
@Haarolean
Copy link
Member

@wernerdv thank you for your contribution!

@wernerdv wernerdv deleted the issues/527 branch March 8, 2025 14:23
@wernerdv
Copy link
Contributor Author

wernerdv commented Mar 8, 2025

@Haarolean @germanosin Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BE: Expose consumer's config props likerequest.timeout.ms
3 participants