Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Remove Maven related files #915

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

Brijeshthummar02
Copy link
Contributor

@Brijeshthummar02 Brijeshthummar02 commented Mar 10, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

issue #913

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Brijeshthummar02 Brijeshthummar02 requested review from a team as code owners March 10, 2025 17:46
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 10, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brijeshthummar02! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean changed the title Remove Maven wrapper and configuration files Infra: Remove Maven related files Mar 10, 2025
@Haarolean Haarolean added scope/infra CI, CD, dev. env, etc. type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Mar 10, 2025
@Haarolean Haarolean added this to the 1.2 milestone Mar 10, 2025
@Haarolean Haarolean merged commit 3048605 into kafbat:main Mar 10, 2025
45 of 48 checks passed
@Haarolean
Copy link
Member

@Brijeshthummar02 thans for your first contribution to kafbat ui!

@Brijeshthummar02
Copy link
Contributor Author

@Haarolean likewise, feel free to drop dm whenever you feel like issue will likely be handled by me.

@Brijeshthummar02 Brijeshthummar02 deleted the mvn branch March 11, 2025 02:08
@Haarolean Haarolean linked an issue Mar 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Infra: Chore: Nuke maven-related files
2 participants