fix(FEC-8298): SOURCE_SELECTED event triggered before the UI ready when the source provided manually #129
Conversation
yairans
changed the title
OrenMe
changed the title
There was a problem hiding this comment.
@yairans I think we better just differentiate this use case of sources provided in the setup call.
IMO we need to separate the sources from rest of config, call the player with all other settings and then call configure with the sources after UI is initialized.
UI relies on certain things in player as well so it's better the player is configured in advance.
There was a problem hiding this comment.
@yairans I think we better just differentiate this use case of sources provided in the setup call.
IMO we need to separate the sources from rest of config, call the player with all other settings and then call configure with the sources after UI is initialized.
UI relies on certain things in player as well so it's better the player is configured in advance.
… source provided manually
yairans
changed the title
| @@ -40,13 +40,16 @@ class KalturaPlayer extends FakeEventTarget { | |||
| constructor(options: KPOptionsObject) { | |||
| super(); | |||
| this._eventManager = new EventManager(); | |||
| this._localPlayer = loadPlayer(options); | |||
| const {sources} = options; | |||
There was a problem hiding this comment.
what happens if sources doesn't exist? what is the value?
There was a problem hiding this comment.
we have default sources object
| this._logger = getLogger('KalturaPlayer' + Utils.Generator.uniqueId(5)); | ||
| this._uiWrapper = new UIWrapper(this, options); | ||
| this._provider = new Provider(options.provider, __VERSION__); | ||
| this._playlistManager = new PlaylistManager(this, options); | ||
| this._playlistManager.configure(options.playlist); | ||
| Object.values(CoreEventType).forEach(coreEvent => this._eventManager.listen(this._localPlayer, coreEvent, e => this.dispatchEvent(e))); | ||
| this._localPlayer.configure({sources}); |
There was a problem hiding this comment.
check if sources exist, don't call if it's null/undefined
Description of the Changes
postpone the
sourcesconfig after the ui initializationCheckLists