Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7971): change media doesn't work after a critical error #135

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 26, 2018

Description of the Changes

reset the error state when loading a new media
depends on kaltura/playkit-js-ui#249

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe
OrenMe previously approved these changes Jun 26, 2018
@yairans yairans merged commit 292876f into master Jun 26, 2018
@yairans yairans deleted the FEC-7971 branch June 26, 2018 13:32
yairans added a commit to kaltura/playkit-js-ui that referenced this pull request Jun 26, 2018
revert the previous fix for this issue: #191
fix by getting config for the engine see kaltura/kaltura-player-js#135
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
revert the previous fix for this issue: #191
fix by getting config for the engine see kaltura/kaltura-player-js#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants