Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEC-8696 ui components #264

Merged
merged 8 commits into from
Sep 16, 2019
Merged

FEC-8696 ui components #264

merged 8 commits into from
Sep 16, 2019

Conversation

esakal
Copy link

@esakal esakal commented Aug 5, 2019

Description of the Changes

add ui components provided by plugins into the configuration object
related PRs:
kaltura/playkit-js#387
kaltura/playkit-js-ui#399

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@esakal esakal self-assigned this Aug 5, 2019
@esakal esakal requested a review from OrenMe August 14, 2019 13:37
@esakal esakal marked this pull request as ready for review August 14, 2019 13:37
OrenMe pushed a commit to kaltura/playkit-js that referenced this pull request Sep 16, 2019
OrenMe
OrenMe previously approved these changes Sep 16, 2019
OrenMe pushed a commit to kaltura/playkit-js-ui that referenced this pull request Sep 16, 2019
@OrenMe OrenMe merged commit 880762e into master Sep 16, 2019
@OrenMe OrenMe deleted the FEC-8696-contrib branch September 16, 2019 13:37
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants