Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config incorrect check for keySystem, isn't a boolean #283

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix: config incorrect check for keySystem, isn't a boolean #283

merged 1 commit into from
Nov 7, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Nov 7, 2019

Description of the Changes

check for existence string instead boolean

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: config keySystem isn't boolean
4000f32 
check for existence string instead boolean
@Yuvalke Yuvalke requested a review from RoyBregman November 7, 2019 14:03
@Yuvalke Yuvalke self-assigned this Nov 7, 2019
@Yuvalke Yuvalke requested review from yairans and OrenMe November 7, 2019 15:40
@Yuvalke Yuvalke merged commit 4280dc5 into master Nov 7, 2019
@Yuvalke Yuvalke deleted the fix-config-keysystem branch November 7, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyBregman RoyBregman RoyBregman approved these changes

@yairans yairans Awaiting requested review from yairans

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @RoyBregman