Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10122): destroy cleanup process #326

Merged
merged 14 commits into from
Jul 2, 2020
Merged

fix(FEC-10122): destroy cleanup process #326

merged 14 commits into from
Jul 2, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jun 15, 2020

Description of the Changes

static class added listeners to the player instance which weren't cleared on destroy.
Add destroy to playlist manager.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested review from OrenMe, yairans and RoyBregman June 15, 2020 08:21
@Yuvalke Yuvalke self-assigned this Jun 15, 2020
@Yuvalke Yuvalke changed the title fix(FEC-10122): destroy clean process fix(FEC-10122): destroy cleanup process Jun 15, 2020
@yairans yairans requested a review from dan-ziv June 15, 2020 08:49
OrenMe
OrenMe previously approved these changes Jun 15, 2020
@Yuvalke Yuvalke merged commit 5fbe11b into master Jul 2, 2020
@Yuvalke Yuvalke deleted the FEC-10122 branch July 2, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants