feat(FEC-10233): plugin async loading support #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RoyBregman please run |
OrenMe
previously requested changes
Nov 23, 2020
OrenMe
reviewed
Nov 25, 2020
Co-authored-by: Oren Me <[email protected]>
…ub.com/kaltura/kaltura-player-js into FEC-10233-Plugin-async-loading-support
OrenMe
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Added a new getter "Ready" in BasePlugin which is resolved by default.
If a plugin wants to make sure load and play don't occur before some async event in the plugin he can override the getter and return a new promise which will be resolved accordingly.
A new Middleware "PluginReadinessMiddleware" was created and added to the beginning of the middlewares chain reaction to make sure all plugin promises are resolved before starting the load / play middleware chain reaction
resolves FEC-10233
CheckLists