Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10680): back-end bumper: the app should decide what bumper will be displayed when also set user bumper #392

Merged
merged 5 commits into from
Dec 29, 2020
Merged

fix(FEC-10680): back-end bumper: the app should decide what bumper will be displayed when also set user bumper #392

merged 5 commits into from
Dec 29, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Dec 21, 2020 •
edited
Loading

Description of the Changes

consider the app plugins config before the provider's

Solves FEC-10680

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans
fix(FEC-10680): back-end bumper: the app should to decide what bumper…
889e552 
… will be displayed when also set user bumper
@yairans yairans requested a review from a team December 21, 2020 11:39
@yairans yairans self-assigned this Dec 21, 2020
@yairans yairans mentioned this pull request Dec 22, 2020
Merged
5 tasks
@OrenMe OrenMe changed the title fix(FEC-10680): back-end bumper: the app should to decide what bumper will be displayed when also set user bumper fix(FEC-10680): back-end bumper: the app should decide what bumper will be displayed when also set user bumper Dec 27, 2020
@yairans yairans merged commit a062427 into master Dec 29, 2020
@yairans yairans deleted the FEC-10680 branch December 29, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe