Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10961): show the thumbnail preview in live #407

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 1, 2021

Description of the Changes

Don't build the default thumbnail preview for live content

Solves FEC-10961

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe
OrenMe previously approved these changes Feb 1, 2021
@yairans yairans merged commit c1ac3fe into master Feb 2, 2021
@yairans yairans deleted the FEC-10961 branch February 2, 2021 11:09
yairans added a commit to kaltura/playkit-js-ui that referenced this pull request Feb 2, 2021
pass `showFramePreview` in live preset and seekbar-live-playback-container 

Solves FEC-10961

Related to kaltura/kaltura-player-js#407
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
pass `showFramePreview` in live preset and seekbar-live-playback-container 

Solves FEC-10961

Related to kaltura/kaltura-player-js#407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants