Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10281): chromecast does not work after playing it once and trying it on another video #417

Merged
merged 3 commits into from
Mar 14, 2021
Merged

fix(FEC-10281): chromecast does not work after playing it once and trying it on another video #417

merged 3 commits into from
Mar 14, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 22, 2021

Description of the Changes

Call also to remote player destroy on player destroy.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Feb 22, 2021
Yuvalke
Yuvalke previously requested changes Feb 22, 2021
View reviewed changes
@dan-ziv dan-ziv requested a review from Yuvalke February 23, 2021 07:40
@dan-ziv dan-ziv mentioned this pull request Mar 11, 2021
Closed
2 tasks
@dan-ziv dan-ziv linked an issue Mar 11, 2021 that may be closed by this pull request
Chromcast does not work after playing it once and trying it on another video #328
Closed
2 tasks
@dan-ziv dan-ziv merged commit 42e7939 into master Mar 14, 2021
@dan-ziv dan-ziv deleted the FEC-10281 branch March 14, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chromcast does not work after playing it once and trying it on another video
3 participants
@dan-ziv @yairans @Yuvalke