Skip to content

Commit

Permalink
fix(FEC-11708): reset cast initiator on disconnect (#72)
Browse files Browse the repository at this point in the history
We set isCastInitiator=true on cast button click, and set it to false if the cast request didn't succeed or the cast menu lost focus.

However, if player A is already casting, when we click on the button in player B, we set isCastInitiator=true but we have no event to indicate that the cast request did not succeed, since a cast request can't be made at all while player A is casting, and so for player B isCastinitiator is not set to false.

When having 3+ players this can cause a situation where multiple players will have isCastInitiator set to true when a player starts casting, which will cause them all to connect to the same remote session.

To prevent this, we need to reset isCastInitiator for ALL players on disconnect.

Fixes FEC-11708.
  • Loading branch information
SivanA-Kaltura authored Nov 23, 2021
1 parent 30595d8 commit dbadddb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cast-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -960,9 +960,9 @@ class CastPlayer extends BaseRemotePlayer {
}
} else {
// savedEntryId === localEntryId if this player's cast session was stopped by the user
this._isCastInitiator = false;
const savedEntryId = this._getSessionEntryId(this._castSession);
if (savedEntryId && savedEntryId === localEntryId) {
this._isCastInitiator = false;
this._setupLocalPlayer();
}
}
Expand Down

0 comments on commit dbadddb

Please sign in to comment.