fix(FEC-11708): V3 - cast on multiple players - if try to cast when other player are casting, the player will be disabled #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
We set isCastInitiator=true on cast button click, and set it to false if the cast request didn't succeed or the cast menu lost focus.
However, if player A is already casting, when we click on the button in player B, we set isCastInitiator=true but we have no event to indicate that the cast request did not succeed, since a cast request can't be made at all while player A is casting, and so for player B isCastinitiator is not set to false.
When having 3+ players this can cause a situation where multiple players will have isCastInitiator set to true when a player starts casting, which will cause them all to connect to the same remote session.
To prevent this, we need to reset isCastInitiator for ALL players on disconnect.
Fixes FEC-11708.
Related PR: kaltura/playkit-js-ui@0470ffa
CheckLists