Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11708): V3 - cast on multiple players - if try to cast when other player are casting, the player will be disabled #72

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Nov 22, 2021

Description of the Changes

We set isCastInitiator=true on cast button click, and set it to false if the cast request didn't succeed or the cast menu lost focus.

However, if player A is already casting, when we click on the button in player B, we set isCastInitiator=true but we have no event to indicate that the cast request did not succeed, since a cast request can't be made at all while player A is casting, and so for player B isCastinitiator is not set to false.

When having 3+ players this can cause a situation where multiple players will have isCastInitiator set to true when a player starts casting, which will cause them all to connect to the same remote session.

To prevent this, we need to reset isCastInitiator for ALL players on disconnect.

Fixes FEC-11708.
Related PR: kaltura/playkit-js-ui@0470ffa

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit dbadddb into master Nov 23, 2021
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-11708-reset-cast-initiator-on-disconnect branch November 23, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants